Skip to content

[0.76] [Telemetry] Add RnwNewArch to MSBuildProperties#14237

Merged
danielayala94 merged 2 commits into
microsoft:0.76-stablefrom
danielayala94:backportRnwNewArch
Jan 6, 2025
Merged

[0.76] [Telemetry] Add RnwNewArch to MSBuildProperties#14237
danielayala94 merged 2 commits into
microsoft:0.76-stablefrom
danielayala94:backportRnwNewArch

Conversation

@danielayala94

@danielayala94 danielayala94 commented Jan 4, 2025

Copy link
Copy Markdown
Contributor

Description

Backport #14208 to 0.76.

Add RnwNewArch and UseFabric properties to MSBuildProperties, indicating if the project is using Paper or Fabric.

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

By using telemetry data, we want to determine the adoption level of Fabric.

Resolves #14047

What

Included RnwNewArch and UseFabric in the properties written into msproperties.g.json (via OutputMSBuildProperties.targets), which are picked up by run-windows to pass all the properties as extraProps for telemetry logging.

Screenshots

image

Testing

Ran run-windows in a debugger and verified that RnwNewArch and UseFabric are written into msproperties.g.json and they are passed to Telemetry.trackCommandEvent().

Changelog

No

Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

@danielayala94 danielayala94 requested a review from a team January 4, 2025 00:00
@danielayala94 danielayala94 requested a review from a team as a code owner January 4, 2025 00:00
@danielayala94 danielayala94 merged commit a271f47 into microsoft:0.76-stable Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants